gnodet commented on PR #2798: URL: https://github.com/apache/cxf/pull/2798#issuecomment-4037013582
## CI Failure Analysis The build failure on JDK 21 (and the cancellation on JDK 17) is caused by **2 checkstyle ImportOrder violations** in the new test files. The other test failures (JMS timeout, tracing, Brave span counts) are pre-existing flaky tests unrelated to this PR. ### Checkstyle errors Both errors are `[ImportOrder]` — "Extra separation in import group": 1. **`CustomJPACriteriaVisitor.java:27`** — blank line between `jakarta.*` and `org.apache.cxf.*` imports 2. **`JPACriteriaQueryVisitorExtensionTest.java:26`** — blank line between `jakarta.*` and `org.apache.cxf.*` imports CXF's checkstyle rules require `jakarta.*` and `org.apache.*` imports to be in the same group (no blank line separator). See `AbstractJPATypedQueryVisitorTest.java` lines 29-40 for the expected pattern. ### Fix In **`CustomJPACriteriaVisitor.java`**, remove the blank line between lines 25-27: ```java // Before (wrong): import jakarta.persistence.metamodel.Bindable; import org.apache.cxf.jaxrs.ext.search.ConditionType; // After (correct): import jakarta.persistence.metamodel.Bindable; import org.apache.cxf.jaxrs.ext.search.ConditionType; ``` In **`JPACriteriaQueryVisitorExtensionTest.java`**, remove the blank line between lines 24-26: ```java // Before (wrong): import jakarta.persistence.criteria.CriteriaQuery; import org.apache.cxf.jaxrs.ext.search.SearchCondition; // After (correct): import jakarta.persistence.criteria.CriteriaQuery; import org.apache.cxf.jaxrs.ext.search.SearchCondition; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
