raoua-eng commented on PR #2798:
URL: https://github.com/apache/cxf/pull/2798#issuecomment-4133116734
Hi @reta @gnodet,
Following the earlier feedback on checkstyle violations in
`cxf-rt-rs-extension-search`, I continued working on the cleanup on top of this
contribution.
I addressed most of the issues reported by:
mvn -pl :cxf-rt-rs-extension-search -am checkstyle:check
I made several follow-up commits for that cleanup, including for example:
-
[JavadocPackage](https://github.com/apache/cxf/commit/c86d5147d1aa336be3d7c39280f6988199299b4c)
- [Formatting /
whitespace](https://github.com/apache/cxf/commit/9850162ccd7a4df4fc990a28650833450e8f417a)
-
[HiddenField](https://github.com/apache/cxf/commit/4d5f6f834ea98ce3551166356e02d90dc1286bed)
-
[MagicNumber](https://github.com/apache/cxf/commit/a0879936799e0577524480b6047d36628b8aee08)
-
[FinalParameters](https://github.com/apache/cxf/commit/4a60cf392d3d40a8f21689d1e86ac739aad9c5fb)
These address items such as JavadocPackage, formatting / whitespace,
HiddenField, MagicNumber, FinalParameters, and other related checkstyle issues.
Since this PR has already been merged, I’m just leaving this here for
visibility.
If useful, I can open a small follow-up PR with the cleanup only.
I can also attach the current / remaining checkstyle output if needed.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
