coheigea commented on PR #3572: URL: https://github.com/apache/cxf/pull/3572#issuecomment-6162334708
Thanks, all four look good. One thing my earlier suggestion caused, sorry: with rawFileName != null, an empty filename="" now counts as a file part. Browsers send exactly that for an HTML form file input that’s left empty, usually with no Content-ID. In EntityPartProvider that part used to be a form field named after its name; now it goes down the file branch and is named by its content id, which is null. Could you use !StringUtils.isEmpty(rawFileName) instead of rawFileName != null, including the rawFileName == null check in EntityPartUtils.createFromAttachment? reports/ and .. would still stay file parts. A test for filename="" alongside testTrailingSeparatorStaysAFilePart would cover it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
