reta commented on code in PR #3572:
URL: https://github.com/apache/cxf/pull/3572#discussion_r4271409996


##########
core/src/main/java/org/apache/cxf/attachment/ContentDisposition.java:
##########
@@ -127,6 +127,13 @@ public String getType() {
         return type;
     }
 

Review Comment:
   @coheigea @dxbjavid I would suggest to consider introducing dedicated 
methods here:
   
   ```
   public String getFilename() {
       return FileUtils.safeFileName(getFilenameRaw());
   }
   
   public String getFilenameRaw() {
       return params.get(FILE_NAME);
   }
   ```
   
   It is a bit difficult to estimate and impact on changing default, so we 
could keep `getFilename()` unchanged and introduce `getFilenameSafe() / 
getFilenameSanitized() ` instead fe.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to