reta commented on code in PR #403:
URL: https://github.com/apache/cxf-xjc-utils/pull/403#discussion_r4293881333


##########
cxf-xjc-plugin/src/main/java/org/apache/cxf/maven_plugin/AbstractXSDToJavaMojo.java:
##########
@@ -301,6 +300,30 @@ public void execute() throws MojoExecutionException {
         }
     }
     
+    /*
+     * The name of the marker file recording that the given schema location 
was processed.
+     * Characters that are invalid in file names are replaced, so a hash of 
the location is
+     * added to keep different locations (e.g. "a/b.xsd" and "a_b.xsd") from 
sharing a marker.
+     */
+    static String getDoneFileName(String location) {
+        String name = location.replace('?', '_')

Review Comment:
   Had this idea, wondering what do you think: 
    - use hash to name a DONE file (it is unique)
    - store location as-is inside (so no need to sanitize the name)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to