reta commented on code in PR #3604:
URL: https://github.com/apache/cxf/pull/3604#discussion_r4313067496
##########
core/src/main/java/org/apache/cxf/common/util/WeakIdentityHashMap.java:
##########
@@ -95,7 +96,8 @@ public V setValue(V value) {
}
public Set<K> keySet() {
reap();
- Set<K> ret = new HashSet<>();
+ // keys are compared by identity, so equal but distinct keys must not
be merged
+ Set<K> ret = Collections.newSetFromMap(new IdentityHashMap<>());
Review Comment:
The `backingStore` is just a `HashMap`, so every key there will be using
equals + hashCode anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
