[GitHub] incubator-daffodil pull request #12: Revised daffodil-io module to require p...

[mbeckerle]

Github user mbeckerle commented on a diff in the pull request:

    https://github.com/apache/incubator-daffodil/pull/12#discussion_r153953270
  
    --- Diff: 
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/ProcessorStateBases.scala
 ---
    @@ -104,11 +117,72 @@ abstract class ParseOrUnparseState protected (
       with SavesErrorsAndWarnings
       with LocalBufferMixin
       with EncoderDecoderMixin
    -  with Logging {
    +  with Logging
    +  with FormatInfo {
    +
    +  final def replacingDecoder: CharsetDecoder = decoderEntry.replacingCoder
    --- End diff --
    
    Look at callers for all these methods and see if some of these can be 
protected or private.


---