Github user mbeckerle commented on a diff in the pull request:
https://github.com/apache/incubator-daffodil/pull/12#discussion_r153948202
--- Diff:
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/grammar/BitOrderMixin.scala
---
@@ -74,9 +74,9 @@ trait BitOrderMixin extends GrammarMixin with
ByteOrderAnalysisMixin { self: Ter
protected final lazy val needsBitOrderChange = {
enclosingTerm.isEmpty || (
optionBitOrder.isDefined &&
- thereIsAByteOrderDefined && // if there is no byte order, then
there's no need for bit order. The two go together. An all-textual format
doesn't need either one.
- (!isKnownSameBitOrder ||
- (isArray && !hasUniformBitOrderThroughout)))
+ thereIsAByteOrderDefined && // if there is no byte order, then
there's no need for bit order. The two go together. An all-textual format
doesn't need either one.
--- End diff --
Do we have a coding standard for sub-expression indenting? This change is
just whitespace change. Eclipse does this automatically on save.
---
