mbeckerle commented on a change in pull request #42: Add back deprecated support for built-in-formats.dfdl.xsd URL: https://github.com/apache/incubator-daffodil/pull/42#discussion_r168553531
########## File path: daffodil-lib/src/main/resources/IBMdefined/GeneralPurposeFormat.xsd ########## @@ -43,7 +43,7 @@ * <xs:schema xmlns:tns="http://www.ogf.org/dfdl/dfdl-1.0/examples/" ... > * * <xs:import namespace="http://www.ogf.org/dfdl/dfdl-1.0/examples/" -* schemaLocation="DFDLGeneralFormatDefinition.xsd"/> +* schemaLocation="DFDLGeneralFormatDefinition.dfdl.xsd"/> Review comment: This change is not correct for this file. I think this file wants to be reverted back to what it was. btw: do we get to remove IBM's copyright on this file, or do we have to keep it and add the ASF license block? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
