mbeckerle commented on a change in pull request #42: Add back deprecated 
support for built-in-formats.dfdl.xsd
URL: https://github.com/apache/incubator-daffodil/pull/42#discussion_r168554878
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/IIBase.scala
 ##########
 @@ -165,7 +165,13 @@ abstract class IIBase( final override val xml: Node, 
xsdArg: XMLSchemaDocument,
     res
   }.value
 
-  final lazy val schemaLocationProperty = getAttributeOption("schemaLocation")
+  final lazy val schemaLocationProperty = {
+    val prop = getAttributeOption("schemaLocation")
+    if (prop.isDefined && prop.get == 
"edu/illinois/ncsa/daffodil/xsd/built-in-formats.xsd") {
+      SDW("schemaLocation property uses deprecated include/import of 
edu/illinois/ncsa/daffodil/xsd/built-in-formats.xsd. Use 
org/apache/daffodil/xsd/DFDLGeneralFormatDefinition.dfdl.xsd instead and change 
the dfdl:format ref to \"GeneralFormat\".")
 
 Review comment:
   So will all our tests that use daffodilTest1 or daffodilNewProperties1 
(which is also defined in built-in-formats) all produce SDWs now, or is there a 
way they are suppressed for our own tests? daffodilNewProperties1 is used quite 
a bit. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to