Hi, I'll make time this weekend to review (source looks mostly OK see below, but want to review the binary), but I see the following issues:
- LICENSE and NOTICE files are mixed up. In the LICENSE file you're supposed to include all licenses for the source code contained in the bundle. This would include BSD, W3C, etc. HOWEVER, I can't find most of these contents actually bundled. What I typically see is a list of files and a pointer to their license, full license text. As far as I can tell, you're not actually bundling these in the source release yet the LICENSE/NOTICE in the source release includes them (most project will include distinct SOURCE and BINARY LICENSE/NOTICE files, since the scope changes; especially with Daffodil since it looks like you bundle a server component as well). The NOTICE should be reserved for only contents specifically indicating a NOTICE must be included. - Did we receive a SGA for the transference of source to the ASF? If so, I would recommend listing the original authors in the NOTICE file (its customary). - For the source imported from Scala, was it modified? John On Fri, Feb 16, 2018 at 2:46 PM Steve Lawrence <[email protected]> wrote: > Hi all, > > I'd like to call a vote to release Apache Daffodil (Incubating) 2.1.0-rc2. > > All distribution packages, including signatures, digests, etc. can be > found at: > > https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.1.0-rc2/ > > Staging artifacts can be found at: > > https://repository.apache.org/content/repositories/orgapachedaffodil-1001/ > > This release has been signed with PGP key 033AE661, corresponding to > [email protected], which is included in the repository's KEYS file. > This key can be found on keyservers, such as: > > http://pgp.mit.edu/pks/lookup?op=get&search=0x033AE661 > > It is also listed here: > > https://people.apache.org/keys/committer/slawrence.asc > > The release candidate has been tagged in git with v2.1.0-rc2. > > For reference, here is a list of all closed JIRAs tagged with 2.1.0: > > > https://issues.apache.org/jira/browse/DAFFODIL-1897?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.1.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC > > For a summary of the changes in this release, see: > > https://daffodil.apache.org/releases/2.1.0/ > > Please review and vote. The vote will be open for at least 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > My vote: +1 > > Thanks, > - Steve >
