stevedlawrence commented on a change in pull request #48: Added noEmptyDefault
warning ID so we can suppress for NACHA.
URL: https://github.com/apache/incubator-daffodil/pull/48#discussion_r171097609
##########
File path:
daffodil-lib/src/main/scala/org/apache/daffodil/exceptions/ThrowsSDE.scala
##########
@@ -91,19 +92,22 @@ trait SavesErrorsAndWarnings {
def schemaDefinitionErrorButContinue(str: String, args: Any*): Unit =
SDEButContinue(str, args: _*)
- /***
+ /**
+ * *
* These functions are now macros as the original code:
* final def schemaDefinitionUnless(testThatWillThrowIfFalse: Boolean, str:
=> String, args: => Any*) = if (!testThatWillThrowIfFalse) SDE(str, args: _*)
* would cause expensive object allocation, even when the
* test would be true and even when the function was inlined
*/
+ @deprecated("2018-02-27", "Must supply a WarnID now.")
def schemaDefinitionWarningUnless(testThatWillWarnIfFalse: Boolean, str:
String, args: Any*): Unit = macro SDEMacros.schemaDefinitionWarningUnlessMacro
/**
* Use this form if you need to be able to suppress the warning
*/
def schemaDefinitionWarningUnless(warnID: WarnID, testThatWillWarnIfFalse:
Boolean, str: String, args: Any*): Unit = macro
SDEMacros.schemaDefinitionWarningUnlessSuppressMacro
+ @deprecated("2018-02-27", "Must supply a WarnID now.")
Review comment:
Can these be removed too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
