stevedlawrence commented on a change in pull request #48: Added noEmptyDefault
warning ID so we can suppress for NACHA.
URL: https://github.com/apache/incubator-daffodil/pull/48#discussion_r171093343
##########
File path: project/Dependencies.scala
##########
@@ -39,7 +39,7 @@ object Dependencies {
lazy val cli = Seq(
"org.fusesource.jansi" % "jansi" % "1.14",
"org.rogach" %% "scallop" % "0.9.5", // new version avail. 2.0.5 requires
code changes
- "net.sf.expectit" % "expectit-core" % "0.8.1" % "test",
+ "net.sf.expectit" % "expectit-core" % "0.8.1" % "test"
Review comment:
As I understand it, SBT 1.x uses the Scala 2.12 compiler for
parsing/compiling the *.sbt files. Scala 2.12 supports trailing commas (see
[SIP-27](http://docs.scala-lang.org/sips/completed/trailing-commas.html)), so
SBT does as well. So although it isn't the norm, this is valid syntax and
shouldn't be the cause of any problems. I'm fine with removing if we're already
updating this file though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services