mbeckerle commented on a change in pull request #48: All SDW have WarnIDs to
support suppression of warnings.
URL: https://github.com/apache/incubator-daffodil/pull/48#discussion_r171116049
##########
File path: project/Dependencies.scala
##########
@@ -18,7 +18,15 @@
import sbt._
object Dependencies {
- lazy val common = core ++ infoset ++ test
+
+ // Note cli added to commmon on purpose.
+ // Due to some obscure bug, updateClassifers was not pulling the
+ // dependencies for the daffodil-cli module into lib_managed properly.
+ // (It found the source jars and javadoc jars, but not the regular code jar
for
+ // Scallop aka org.rogach.)
+ // So compilation would fail for daffodil-cli from missing org.rogach
library.
+ // Added to here forces these dependencies to be resolved.
+ lazy val common = core ++ infoset ++ test ++ cli
Review comment:
Why doesn't sbt clean automatically clean daffodil-cli like it does all the
other subprojects?
The only exceptional behavior we need/want is for test and that's simply
because they take too long to run. We don't want to run the cli tests
automatically, but for everything else we *do* want it to act across
daffodil-cli as well.
Or can this not be achieved?
I can revert this change certainly, and the workaround is fine, but treating
daffodil-cli as an entirely separate project but still having it be a
subproject is awkward.
Does any sbt task act across all the sub modules including daffodil-cli, or
is daffodil-cli entirely separate now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
