mbeckerle commented on a change in pull request #48: All SDW have WarnIDs to
support suppression of warnings.
URL: https://github.com/apache/incubator-daffodil/pull/48#discussion_r171119796
##########
File path:
daffodil-lib/src/main/scala/org/apache/daffodil/exceptions/ThrowsSDE.scala
##########
@@ -57,7 +57,8 @@ trait ThrowsSDE {
final def schemaDefinitionError(str: String, args: Any*): Nothing = SDE(str,
args: _*) // long form synonym
Review comment:
Above at line 85, missed deprecating another form of SDW call without
warnID. Need to find where these are all called also and add more warnIDs.
Why this review tool won't let me put a comment on an unchanged line of a
file.... is annoying!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
