mbeckerle commented on a change in pull request #70: Adding property
binaryCalendarRep with values "binarySeconds" and "bi…
URL: https://github.com/apache/incubator-daffodil/pull/70#discussion_r189980319
##########
File path:
daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpacalbin100_01.dfdl.xsd
##########
@@ -52,7 +53,8 @@
<xs:element name="testBinaryMilliseconds" type="xs:dateTime">
<xs:annotation>
<xs:appinfo source="http://www.ogf.org/dfdl/";>
- <dfdl:element
binaryCalendarRep="binaryMilliseconds"
binaryCalendarEpoch="2009-12-24T05:15:00+05:00"/>
+ <dfdl:element
binaryCalendarRep="binaryMilliseconds"
binaryCalendarEpoch="2009-12-24T05:15:00+05:00"
+ calendarPatternKind="explicit"
calendarPattern="yyyy-MM-dd'T'HH:mm:ssZZZZ" />
Review comment:
For binary calendars, patterns really only make sense for packed decimal or
BCD representations. For twos-complement integer representations the DFDL spec
is clear the pattern is not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
