mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204081776
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala ########## @@ -618,8 +622,9 @@ final class ElementRuntimeData( @TransientParam targetNamespaceArg: => NS, @TransientParam thisElementsNamespaceArg: => NS, @TransientParam optSimpleTypeRuntimeDataArg: => Option[SimpleTypeRuntimeData], - @TransientParam minOccursArg: => Option[Int], - @TransientParam maxOccursArg: => Option[Int], + @TransientParam minOccursArg: => Long, + @TransientParam maxOccursArg: => Long, Review comment: Correct, but if we decided to change the infoset to allow a more complex multi-array representation.... or if a new JVM spec comes out where Long are somehow accepted and arrays can be bigger.... So these are Long because conceptually DFDL doesn't restrict them. The Option went away because the code insures that for scalars these are 1, 1, and for unbounded maxOccurs -1 is the convention used everywhere. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
