mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204082615
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/DelimiterParsers.scala
##########
@@ -158,7 +158,7 @@ class DelimiterTextParser(
return
} else {
// no match and no ES in delims
- PE(start, "Delimiter not found.")
+ PE(start, "%s '%s' not found.", delimiterType.toString,
start.mpstate.delimiters.last.lookingFor)
Review comment:
Doesn't work great tho. Sometimes you see %NL; '%NL;' not found. Other times
'xy' where x and y are those little picture Unicode chars for newline. In the
runtime code there is not currently a way to go from the delimiter or set of
delimiters being found, to the schema author's expression of those delimiters.
This is needed for a good diagnostic. I'll report this inconsistency as a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
