stevedlawrence commented on a change in pull request #88: Daffodil 1919
separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r208276189
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ParticleMixin.scala
##########
@@ -117,23 +140,31 @@ trait ParticleMixin extends RequiredOptionalMixin {
self: ElementBase =>
case _ => max.toInt
}
}
+
+ /**
+ * Can have a varying number of occurrences.
+ */
+ final override lazy val isVariableOccurrences = minOccurs != maxOccurs
Review comment:
Should this take into account occursCountKind? When should this be used
rather than something like ``(isOptional || isArray)``? Maybe add scaladoc to
clarify that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
