stevedlawrence commented on a change in pull request #88: Daffodil 1919
separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r208276759
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ParticleMixin.scala
##########
@@ -117,23 +140,31 @@ trait ParticleMixin extends RequiredOptionalMixin {
self: ElementBase =>
case _ => max.toInt
}
}
+
+ /**
+ * Can have a varying number of occurrences.
+ */
+ final override lazy val isVariableOccurrences = minOccurs != maxOccurs
final lazy val isFixedOccurrences = {
- // TODO optimizations to take scope into consideration. E.g.,
+ // TODO maybe do optimizations to take scope into consideration. E.g.,
// We could be in a context where the value of our occursCount expression
// will always be a constant.
occursCountKind == OccursCountKind.Fixed
}
Review comment:
Similar to the above, what if occursCountKind is implicit, but minOccurs ==
maxOccurs? That's similar to fixOccurrences right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
