mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r208394364
##########
File path:
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/LayeredSequenceUnparser.scala
##########
@@ -17,13 +17,14 @@
package org.apache.daffodil.processors.unparsers
-import org.apache.daffodil.processors.{ LayerTransformerEv,
ModelGroupRuntimeData }
+import org.apache.daffodil.processors.LayerTransformerEv
import org.apache.daffodil.io.DirectOrBufferedDataOutputStream
+import org.apache.daffodil.processors.SequenceRuntimeData
-class LayeredSequenceUnparser(ctxt: ModelGroupRuntimeData,
+class LayeredSequenceUnparser(ctxt: SequenceRuntimeData,
layerTransformerEv: LayerTransformerEv,
- childUnparser: Unparser)
- extends SequenceCombinatorUnparser(ctxt, Vector(childUnparser)) {
Review comment:
Yes, all these should be vector. In the runtime we don't map/foreach them,
we use indexing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services