mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r209012952
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala
 ##########
 @@ -37,15 +33,63 @@ import org.apache.daffodil.schema.annotation.props.Found
 import org.apache.daffodil.schema.annotation.props.PropertyLookupResult
 import org.apache.daffodil.processors.LayerTransformerEv
 import org.apache.daffodil.util.Maybe
+import org.apache.daffodil.schema.annotation.props.SeparatorSuppressionPolicy
+import org.apache.daffodil.schema.annotation.props.gen.SeparatorPosition
+import org.apache.daffodil.processors.SeparatorParseEv
+import org.apache.daffodil.processors.ModelGroupRuntimeData
+import org.apache.daffodil.schema.annotation.props.gen.LayerLengthUnits
+import org.apache.daffodil.processors.SeparatorUnparseEv
 
+/**
+ * Base for anything sequence-like.
+ *
+ * Sequences, group refs to sequences, and the implied sequences
+ * that are choice branches, are all instances.
+ */
 abstract class SequenceTermBase(
   final override val xml: Node,
   final override val parent: SchemaComponent,
   final override val position: Int)
   extends ModelGroup
+  with SequenceGrammarMixin {
+
+  def separatorSuppressionPolicy: SeparatorSuppressionPolicy
+
+  def sequenceKind: SequenceKind
+
+  def separatorPosition: SeparatorPosition
+
+  def isLayered: Boolean
+
+  // def hasSeparator: Boolean
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to