mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r209082255
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesLengthKind.scala
 ##########
 @@ -335,7 +335,7 @@ case class LiteralNilDelimitedEndOfData(eb: ElementBase)
 
 case class PrefixLength(e: ElementBase) extends UnimplementedPrimitive(e, 
e.lengthKind == LengthKind.Prefixed)
 
-class OptionalInfixSep(term: Term, sep: => Gram, guard: Boolean = true) 
extends Terminal(term, guard) {
+class OptionalInfixSep(term: Term, sep: Gram) extends Terminal(term, 
!sep.isEmpty) {
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to