mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r209038756
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/grammar/TermGrammarMixin.scala
 ##########
 @@ -128,46 +96,31 @@ trait TermGrammarMixin
     nearestEnclosingSequence
   }
 
-  private def hasES = nearestEnclosingSequence != None
-  private def ignoreES = inChoiceBeforeNearestEnclosingSequence == true
+  protected final def hasES = nearestEnclosingSequence != None
 
 Review comment:
   Removed. Not needed. Only used one place. Dropped this definition and next 
one ignoreES.
   
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to