mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r209036421
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/grammar/SequenceGrammarMixin.scala
 ##########
 @@ -64,6 +150,20 @@ trait SequenceGrammarMixin extends GrammarMixin { self: 
SequenceTermBase =>
     else false
   }
 
-  final lazy val hasSeparator = separatorParseEv.isKnownNonEmpty
+  lazy val hasSeparator = separatorParseEv.isKnownNonEmpty
+
+  lazy val sequenceSeparator = prod("separator", hasSeparator) {
+    //
+    // TODO: (JIRA DFDL-1400) The separators may be in a different encoding 
than the terms
+    // that they separate.
+    //
+    // So we must allow for a change of encoding (which may also imply a change
+    // of bit order)
+    //
+    // However, this isn't the same as just plopping down a bitOrderChange ~ 
encodingChange, since
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to