stevedlawrence commented on a change in pull request #129: Cross Testing
Capability with IBM DFDL
URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r229037137
##########
File path:
daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -275,16 +284,17 @@ class DFDLTestSuite private[tdml] (
// We call it an UnparserTestCase
//
val unparserTestCases = (ts \ "unparserTestCase").map { node =>
UnparserTestCase(node, this) }
- val testCases: Seq[TestCase] = parserTestCases ++
- unparserTestCases
- val duplicateTestCases = testCases.groupBy { _.name }.filter { case (name,
seq) => seq.length > 1 }
- if (duplicateTestCases.size > 0) {
+ val testCases: Seq[TestCase] = parserTestCases ++ unparserTestCases
+ val duplicateTestCases = testCases.groupBy {
+ _.tcName
+ }.filter { case (name, seq) => seq.length > 1 }
+ if (duplicateTestCases.nonEmpty) {
duplicateTestCases.foreach {
case (name, _) =>
System.err.println("TDML Runner: More than one test case for name
'%s'.".format(name))
Review comment:
Should duplicate test names be a TDMLException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
