stevedlawrence commented on a change in pull request #129: Cross Testing
Capability with IBM DFDL
URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r229034022
##########
File path:
daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -209,8 +216,9 @@ class DFDLTestSuite private[tdml] (
// System.err.println("TDMLRunner Error: " + exception.getMessage())
isLoadingError = true
}
+
def fatalError(exception: SAXParseException) = {
- loadingExceptions == exception +: loadingExceptions
+ loadingExceptions = exception :: loadingExceptions
// System.err.println("TDMLRunner Fatal Error: " +
exception.getMessage())
Review comment:
Interesting, looks like we were completely ignoring warnings and
fatalErrors? Surprised the scala compiler didn't warn about this, it's clearly
wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
