efinnegan commented on a change in pull request #136: Changing to ignore attributeFormDefault URL: https://github.com/apache/incubator-daffodil/pull/136#discussion_r233662626
########## File path: daffodil-test-ibm1/src/test/scala-debug/org/apache/daffodil/IBMTests2.scala ########## @@ -44,10 +44,8 @@ class IBMTestsThatThrow { lazy val runner1 = new DFDLTestSuite(Misc.getRequiredResource(tdml1)) lazy val runner2 = new DFDLTestSuite(Misc.getRequiredResource(tdml2)) - @Test def test_scoping_define_format_8_04() { runner1.runOneTest("scoping_define_format_8_04") } //DFDL-565 - attributeFormDefault='qualified' - - @Test def test_scoping_default_format_8_01() { runner1.runOneTest("scoping_default_format_8_01") } // DFDL-565 attributeFormDefault='qualified' - @Test def test_scoping_define_format_8_01() { runner1.runOneTest("scoping_define_format_8_01") } // DFDL-565 attributeFormDefault='qualified' + @Test def test_scoping_default_format_8_01() { runner1.runOneTest("scoping_default_format_8_01") } // Attribute "encodingErrorPolicy" was already specified - bug in IBM test + @Test def test_scoping_define_format_8_01() { runner1.runOneTest("scoping_define_format_8_01") } // Attribute "encodingErrorPolicy" was already specified - bug in IBM test Review comment: They also need textOutputMinLength added. I wasn't sure if we wanted to change these tests since they were from IBM. Is it ok to update them? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services