stevedlawrence commented on a change in pull request #140: TDML Runner and test
changes for Cross Validation with IBM.
URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234630857
##########
File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
##########
@@ -1227,7 +1226,7 @@ object Main extends Logging {
println(formatStr.format(headers: _*))
tests.foreach { testPair =>
testPair match {
- case (name, Some(test)) => println(formatStr.format(name,
test.model, test.root, test.description))
+ case (name, Some(test)) => println(formatStr.format(name,
test.model, test.rootName, test.description))
case (name, None) => println(formatStr.format(name, "[Not
Found]", "", ""))
}
Review comment:
When we call test.run() below, does it make sense to catch the new
TDMLTestNotCompatibleException and display it as skipped or not compatible
rather than marking it as a failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
