stevedlawrence commented on a change in pull request #140: TDML Runner and test
changes for Cross Validation with IBM.
URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234703934
##########
File path: project/Dependencies.scala
##########
@@ -29,6 +29,7 @@ object Dependencies {
"xml-resolver" % "xml-resolver" % "1.2",
"commons-io" % "commons-io" % "2.6",
"jline" % "jline" % "2.14.6",
+ "junit" % "junit" % "4.12", // needed for TDML runner use of
AssertionViolationException
Review comment:
I'd avoid setting junit as a core dependency to all projects. It's really
only needed as a compile dependency for the TDML project--the other projects
don't need it. Maybe the best way to do this is to create a new junit
dependency val, and add just that to the tdml project, e.g.:
```scala
// Dependencies.scala
lazy val junit = "junit" % "junit" % "4.12"
lazy val test = Seq(
junit % "it,test",
"com.novocode" % "junit-interface" % "0.11" % "it,test",
"org.scalacheck" %% "scalacheck" % "1.14.0" % "it,test"
)
// build.sbt
lazy val tdml = Project("daffodil-tdml", ...)
...
.settings(libraryDependencies += Dependencies.junit)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
