mbeckerle commented on a change in pull request #152: Daffodil 2028 cross test URL: https://github.com/apache/incubator-daffodil/pull/152#discussion_r241088326
########## File path: daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/nested-separator-delimited.tdml ########## @@ -21,7 +21,7 @@ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xmlns:dfdl="http://www.ogf.org/dfdl/dfdl-1.0/"; xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:ex="http://example.com"; xmlns="http://example.com"; - defaultImplementations="ibm dfdl"> + defaultImplementations="ibm daffodil"> Review comment: Might as well add validation to the tdml XSD so that this mistake can't be made. We've already chosen to "own" the names of these tokens. I.e., they're not class names anymore. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
