mbeckerle commented on a change in pull request #152: Daffodil 2028 cross test
URL: https://github.com/apache/incubator-daffodil/pull/152#discussion_r241108962
##########
File path:
daffodil-lib/src/main/resources/org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd
##########
@@ -93,6 +101,17 @@
utf16Width="fixed"
/>
</dfdl:defineFormat>
+
+ <dfdl:defineFormat name="GeneralFormat">
+ <dfdl:format ref="GeneralFormatOriginal" />
+ </dfdl:defineFormat>
+
+ <dfdl:defineFormat name="GeneralFormatForCrossTesting">
+ <dfdl:format ref="GeneralFormatOriginal"
+ calendarTimeZone="UTC"
+ encodingErrorPolicy="error"
+ />
+ </dfdl:defineFormat>
Review comment:
Only hassle is then to use it you have to include a different file. There's
500+ include statements to change (eventually). As opposed to 500+
ref="GeneralFormat" statements. One would need to change both.
Maybe this shouldn't be GeneralFormatForCrossTesting, but
GeneralFormatPortable ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
