stevedlawrence commented on a change in pull request #158: Daffodil 1080 sequences and separators - preliminary review URL: https://github.com/apache/incubator-daffodil/pull/158#discussion_r242158054
########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SeparatedSequenceUnparsers.scala ########## @@ -126,8 +126,26 @@ class ScalarOrderedSeparatedSequenceChildUnparser( override def unparse(state: UState) = childUnparser.unparse1(state) } -class RepOrderedSeparatedSequenceChildUnparser( - childUnparser: Unparser, +class ScalarOrderedSeparatedSequenceChildUnparser(childUnparser: Unparser, + srd: SequenceRuntimeData, + trd: TermRuntimeData, + sep: Unparser, + spos: SeparatorPosition, + ssp: SeparatorSuppressionPolicy, + ssAlgorithm: SeparatorSuppressionMode) + extends ScalarOrderedSeparatedSequenceChildUnparserBase(childUnparser, srd, trd, sep, spos, ssp, ssAlgorithm) + +class PotentiallyTrailingGroupSeparatedSequenceChildUnparser(childUnparser: Unparser, Review comment: Seems like the mixin doesn't even really do much? Do you expect more stuff in here as this matures? Maybe it should just beome a boolean parameter that is checked in the right places? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
