stevedlawrence commented on a change in pull request #158: Daffodil 1080 sequences and separators - preliminary review URL: https://github.com/apache/incubator-daffodil/pull/158#discussion_r242147873
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala ########## @@ -82,8 +81,7 @@ abstract class SequenceTermBase( * has the sequence properties. So actual sequences, group refs to them, * but NOT implied sequences inside choice branches. */ -abstract class SequenceGroupTermBase( - xml: Node, +abstract class SequenceGroupTermBase(xml: Node, Review comment: It migth be worth at just being more explicit about how you add changes. Instead of doing something like ``git add .`` or ``git commit -a``, instead use ``git add -p``. The ``-p`` flag shows each hunk of a diff separately and lets you decide whether or not you want to add that hunk to the index. For changes that are purely whitespace and unrelated to what you're doing, just ignore hunks. Also helpful is ``git checkout -p``, which is the same idea but lets you undo specifc hunks. So you chould alternative do ``git checkout -p`` and remove all whitespace changes you don't care about, and then do a commit -a at the end. Going hunk by hunk also forces you to look at every change, and sortof acts as a pre-review. Helpful to weed out the easy stuff. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
