stevedlawrence commented on a change in pull request #162: Properly handle
malformed binding files
URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246885930
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala
##########
@@ -472,7 +472,11 @@ final class SchemaSet(
}
val newNS = matchingDVs.head.namespace
- val newBinding = Binding(v.varQName.local, Some(newNS), v.varValue)
+ val newBinding = try {
+ Binding(v.varQName.local, Some(newNS), v.varValue)
+ } catch {
+ case e: BindingException => this.SDE("Exception when processing
external variable %s: %s", v.varQName, e.getMessage)
Review comment:
I think the error message ends up a little verbose. The BindingException has
a string like:
```Exception when processing external variable binidng file: %s```
So combine that with the SDE and the message would look like:
```Exception when processing external variable %s: Exception when processing
external variable binidng file: %s"```
So the message would end up duplicated, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
