stevedlawrence commented on a change in pull request #162: Properly handle 
malformed binding files
URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246886373
 
 

 ##########
 File path: 
daffodil-lib/src/main/scala/org/apache/daffodil/externalvars/Binding.scala
 ##########
 @@ -45,6 +45,9 @@ class Binding(val varQName: RefQName, val varValue: String, 
scope: scala.xml.Nam
       GlobalQName(varQName.prefix, varQName.local, varQName.namespace)
 }
 
+case class BindingException(message: String)
+  extends Exception("Exception when processing external variable binidng file: 
%s".format(message))
 
 Review comment:
   Also, a Binding doesn't necessarily need to come from a "file". Like it 
could from an API or the CLI. I imagine an error in one of those would still 
cause this Exception? Maybe just remove the work "file" if that's the case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to