mbeckerle commented on a change in pull request #205: Update Line counter for
new modules and schemas.
URL: https://github.com/apache/incubator-daffodil/pull/205#discussion_r273475827
##########
File path: daffodil-lib/src/test/scala/LineCounter.scala
##########
@@ -116,20 +120,20 @@ trait LineCounterBase {
def pairs: List[(String, Int)]
- final def total = pairs.map { _._2 }.sum
+ final lazy val total = pairs.map { _._2 }.sum
protected final def linesWithoutCopyright(f: File): List[String] = {
Review comment:
I think this function never worked. I didn't see any significant change in
numbers because of this (not more than a few percent anyway).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
