stevedlawrence commented on a change in pull request #205: Update Line counter
for new modules and schemas.
URL: https://github.com/apache/incubator-daffodil/pull/205#discussion_r273444252
##########
File path: daffodil-lib/src/test/scala/LineCounter.scala
##########
@@ -116,20 +120,20 @@ trait LineCounterBase {
def pairs: List[(String, Int)]
- final def total = pairs.map { _._2 }.sum
+ final lazy val total = pairs.map { _._2 }.sum
protected final def linesWithoutCopyright(f: File): List[String] = {
Review comment:
This function no longer removes the copyright. Maybe it didn't work all that
well? Seems like this is going to increase line numbers alot. Doesn't seem
unreasonable, but just have to note that we shouldn't compare old numbers with
new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
