bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r275853792
########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/DaffodilTunables.scala ########## @@ -72,6 +72,20 @@ case class DaffodilTunables( // val requireBitOrderProperty: Boolean = false, // + // If true, require that the choiceDispatchKeyKind property is specified. If false, use a Review comment: What is the appropriate usage of scaladoc here? Since these are all class parameters, it would seem that the correct style would be to move all of the documentation to above the class with a bunch of @param annotations, and not have any comment where they are declared. Is this desired? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
