bsloane1650 commented on a change in pull request #207: Added support for
enumerations and TypeValueCalc
URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278999549
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/QuasiElementDecl.scala
##########
@@ -40,9 +40,25 @@ sealed class LocalElementDecl(
* DetachedElementDecl is used as a place where properties related to the
* prefix simpel type can be accessed.
*/
-final class DetachedElementDecl(
+sealed abstract class QuasiElementDeclBase(
val detachedReference: ElementBase,
xml: Node,
parent: SchemaComponent)
extends LocalElementDecl(xml, parent, -1){
}
+
+final class PrefixLengthQuasiElementDecl(
+ detachedReference: ElementBase,
+ xml: Node,
+ parent: SchemaComponent)
+ extends QuasiElementDeclBase(detachedReference, xml, parent){
+}
+
+final class RepTypeQuasiElementDecl(
+ detachedReference: ElementBase,
+ xml: Node,
+ parent: SchemaComponent)
+ extends QuasiElementDeclBase(detachedReference, xml, parent){
+
+ override lazy val isQuasiElement = true
Review comment:
Probably just an artifact of how this code was written. There was a period
where (what became) PrefixLengthQuasiElementDecl and RepTypeQuasiElementDecl
didn't ave a common QuasiElementDeclBase supertype. Moving this override to
Base doesn't seem to break anything, so I assume that is what was meant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
