mbeckerle commented on issue #201: Fix bug in handling parse errors URL: https://github.com/apache/incubator-daffodil/pull/201#issuecomment-484766372 Yes I think both toParseError and toUnparseError should be using Maybe(this) for the cause. Both should be chaining the exceptions the same way. The concept here. Innermost exception specifies a format string. Enclosing exceptions have causes only, and *never* have format strings. At actual message creation time each exception contributes to the ultimate message string based on its class name. So you should get "Parse Error (caused by) Expression Evaluation Error: actual message string from innermost class goes here". Though I think "(caused by)" is a bit much. I'd just use a ":".
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
