stevedlawrence commented on a change in pull request #210: Add midBitsToEnd
layer transform
URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278097653
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala
##########
@@ -655,6 +656,18 @@ trait LayeringRuntimeValuedPropertiesMixin
Nope
}
}
+
+ final lazy val maybeLayerTransformArgsEv = {
+ if(optionLayerTransformArgsRaw.isDefined){
Review comment:
Minor whitespce issue here. Should be ``if (foo) {``.
Also, (this might be a question for Mike) this makes it so that
``dfdl:layerTransformArgs`` is optional. That seems reasonable since not all
layers have arguments, but that doesn't seem very DFDL-like. Should this
property be required if dfdl:layerTransform is set? This would mean that if a
layerTransform does not expect arguments this property must be the empty
string. And what happens if a non-empty string is provied for a layerTransform
that does not use arguments? Are they ignored, or is that an SDE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
