stevedlawrence commented on a change in pull request #210: Add midBitsToEnd
layer transform
URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278106411
##########
File path:
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_part1_simpletypes.xsd
##########
@@ -794,6 +794,17 @@
</xsd:documentation>
</xsd:annotation>
</xsd:enumeration>
+ <xsd:enumeration value="midBitsToEnd">
+ <xsd:annotation>
+ <xsd:documentation><![CDATA[
+ Move the bits with indecis [x, x+y] to
+ the end of the layer block.
+
+ x,y are provided as a space delimated list in layerTransformArgs
Review comment:
I wonder if we should define a format for layerTransformArgs so that all
layer transforms can use common code to get the args? If so, thoughts on using
key/value pairs instead of positional args? Makes the args a bit more flexible
and self-documenting. So the property might look something like:
```xml
<xs:sequence ... dfdl:layerTransformArgs="firstBitIndex=8 numBits=2">
```
I also think this documentation could be improved, but maybe more thorough
documentation is better suited for the wiki or the website? We should update
the https://daffodil.apache.org/dfdl-extensions/ page to include documentation
for the transform feature and the different transforms and their arguments.
Also there's a typo in "indices".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
