mbeckerle commented on a change in pull request #207: Added support for
enumerations and TypeValueCalc
URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279822070
##########
File path:
daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/PropertyScoping.scala
##########
@@ -52,6 +52,11 @@ sealed abstract class PropertyLookupResult(val pname:
String) extends Serializab
* for the schema file.
*/
def isFromDefaultFormat: Boolean
+
+ lazy val toOption = this match{
Review comment:
If a def, then every time toOption is called this will box a new Some(x)
object. If this is immutable, then lazy val seems the right choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
