mbeckerle commented on a change in pull request #207: Added support for
enumerations and TypeValueCalc
URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279825054
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/CompiledExpression.scala
##########
@@ -55,7 +55,8 @@ class ExpressionCompiler[T <: AnyRef] extends
ExpressionCompilerBase[T] {
namespaces: NamespaceBinding,
compileInfoWherePropertyWasLocated: DPathCompileInfo,
isEvaluatedAbove: Boolean,
- host: OOLAGHost): CompiledExpression[T] = {
+ host: OOLAGHost,
+ compileInfo: DPathCompileInfo): CompiledExpression[T] = {
Review comment:
As I recall,.... compileInfo is for the component on which we are doing the
compilation. When compiling a property-expression however, that property may
not have been expressed directly on the component, but elsewhere. E.g.,
dfdl:byteOrder="{ $dfdl:byteOrder }" appearing at top level. We need the
compile info to tell us where the property was expressed for diagnostic
purposes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
