mbeckerle commented on a change in pull request #218: Implement
dfdl:choiceLength='explicit'
URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r284819999
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SpecifiedLengthParsers.scala
##########
@@ -132,6 +133,20 @@ class SpecifiedLengthExplicitParser(
}
}
+class SpecifiedLengthChoiceParser(
+ eParser: Parser,
+ erd: RuntimeData,
+ lengthEv: Evaluatable[JLong],
+ toBits: Int)
+ extends SpecifiedLengthParserBase(eParser, erd) {
+
+ final override def getBitLength(s: PState): MaybeULong = {
+ val nBytesAsAny = lengthEv.evaluate(s)
Review comment:
suggest name choiceLengthEv. There is already a lengthEv, so this is
confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
