mbeckerle commented on a change in pull request #218: Implement
dfdl:choiceLength='explicit'
URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290497131
##########
File path:
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLengthUnparsers.scala
##########
@@ -428,3 +431,39 @@ class SpecifiedLengthPrefixedUnparser(
}
}
+
+class ChoiceLengthUnparser(
+ eUnparser: Unparser,
+ rd: ChoiceRuntimeData,
+ targetLengthInBits: Long)
+ extends CombinatorUnparser(rd)
+ with StreamSplitter {
+
+ override lazy val runtimeDependencies = Vector()
+ override lazy val childProcessors = Vector(eUnparser)
+
+
+ private var maybeDOSStart : Maybe[DataOutputStream] = Maybe.Nope
Review comment:
These slots are state that will not be thread safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
