stevedlawrence opened a new pull request #247: Fix unused properties related to implied choice sequences URL: https://github.com/apache/incubator-daffodil/pull/247 When a ChoiceBranchImpliedSequence was created, because groupMembers was not overridden, it would actually create a complete duplicate of all the children terms because that's what the ModelGroup groupMembers that it inherits does. This meant that properties would be cached on different terms than we checked for unused properties, which lead to warnings. This overrides groupMembers for ChoiceBranchImpliedSequence so that it does not create new terms, but is instead just a sequence of the Term it wraps. This allows all the same behavior provided by the implied sequence, but 1) removes the duplicate Terms and 2) allows correct caching/checking of unused properties. DAFFODIL-2163
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
