mbeckerle commented on a change in pull request #253: Support terminators and
initiators containing %ES;
URL: https://github.com/apache/incubator-daffodil/pull/253#discussion_r298289530
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DFDLDelimiter.scala
##########
@@ -602,3 +619,15 @@ class WSPStarDelim extends WSPBase with WSP {
def unparseValue(outputNewLine: String): String = ""
}
+
+// This delimiter matches an empty space which effectively is always a
+// successful match without moving the character position. This effectively
+// acts as a maker that empty match is allowed
Review comment:
Should be scaladoc.
Please add a little more description of why this isn't a stupid-nonsensical
thing to do. That ES as a terminator when lengthKind is other than 'delimited'
is a way of indicating an optional terminator, but that this DFA/scanner is
used to consume delimiters in that case as well. This class establishes the
invariant that there is always a DelimBase object used when "scanning", even
when we're "scanning for nothing".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
