mbeckerle commented on a change in pull request #253: Support terminators and initiators containing %ES; URL: https://github.com/apache/incubator-daffodil/pull/253#discussion_r298290733
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/dfa/Rules.scala ########## @@ -735,3 +735,19 @@ class NLState(states: => ArrayBuffer[State], val nextState: Int, val stateNum: I def checkMatch(charIn: Char): Boolean = isNLNotCR(charIn) || isCR(charIn) } + + +class ESState(states: => ArrayBuffer[State], val nextState: Int, val stateNum: Int) Review comment: Add scaladoc making the point that this is a degenerate kind of rule that just succeeds immediately to handle the empty-string corner case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
